[webkit-reviews] review granted: [Bug 98968] REGRESSION: Unable to scroll with trackpad on some websites after r130783 : [Attachment 168095] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Beth Dakin
<bdakin at apple.com>'s request for review:
Bug 98968: REGRESSION: Unable to scroll with trackpad on some websites after
r130783
https://bugs.webkit.org/show_bug.cgi?id=98968

Attachment 168095: Patch
https://bugs.webkit.org/attachment.cgi?id=168095&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=168095&action=review


> Source/WebCore/page/scrolling/ScrollingStateScrollingNode.cpp:85
> +    m_changedProperties = ViewportRect | ContentsSize |
NonFastScrollableRegion | WheelEventHandlerCount
> +	   | ShouldUpdateScrollLayerPositionOnMainThread |
HorizontalScrollElasticity | VerticalScrollElasticity
> +	   | HasEnabledHorizontalScrollbar | HasEnabledVerticalScrollbar |
HorizontalScrollbarMode
> +	   | VerticalScrollbarMode | ScrollOrigin | RequestedScrollPosition;

Would be nicer if the enum had an 'All' value that was 0xFF or the OR of all
the values.