[webkit-reviews] review granted: [Bug 98959] check-layout.js should always dumpAsText : [Attachment 168079] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 10 16:36:09 PDT 2012


Tony Chang <tony at chromium.org> has granted Ojan Vafai <ojan at chromium.org>'s
request for review:
Bug 98959: check-layout.js should always dumpAsText
https://bugs.webkit.org/show_bug.cgi?id=98959

Attachment 168079: Patch
https://bugs.webkit.org/attachment.cgi?id=168079&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=168079&action=review


> LayoutTests/css3/flexbox/flex-item-child-overflow.html:-27
> -<div data-expected-height=0 class="flexbox">
> -    <div data-expected-height=0>
> -	   <div data-offset-y=0 data-expected-height=20></div>

I would convert this to not be a ref-test since we do want to verify that the
parent boxes have 0 height.


More information about the webkit-reviews mailing list