[webkit-reviews] review granted: [Bug 93958] Pageload tests should measure memory usage : [Attachment 167881] proposed patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Zoltan Horvath
<zoltan at webkit.org>'s request for review:
Bug 93958: Pageload tests should measure memory usage
https://bugs.webkit.org/show_bug.cgi?id=93958

Attachment 167881: proposed patch
https://bugs.webkit.org/attachment.cgi?id=167881&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=167881&action=review


> Tools/Scripts/webkitpy/performance_tests/perftest.py:4
> +# Copyright (C) 2012 Zoltan Horvath (zoltan at webkit.org), Adobe Systems
Incorporated.
> +# All rights reserved.

Can we fit this in one line?

> Tools/Scripts/webkitpy/performance_tests/perftest_unittest.py:159
> +					  + 'RESULT some-test: Malloc= 10.0
bytes\nmedian= 10 bytes, stdev= 0.0 bytes, min= 10 bytes, max= 10 bytes\n'
> +					  + 'RESULT some-test: JSHeap= 5.0
bytes\nmedian= 5 bytes, stdev= 0.0 bytes, min= 5 bytes, max= 5 bytes\n')

Wrong indentation. + should be exactly 4 spaces to the right of
self.assertEqual.