[webkit-reviews] review requested: [Bug 97006] Invalid values for media query features are not handled : [Attachment 168041] Patch 2

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 10 11:17:19 PDT 2012


Alexander Shalamov <alexander.shalamov at gmail.com> has asked  for review:
Bug 97006: Invalid values for media query features are not handled
https://bugs.webkit.org/show_bug.cgi?id=97006

Attachment 168041: Patch 2
https://bugs.webkit.org/attachment.cgi?id=168041&action=review

------- Additional Comments from Alexander Shalamov
<alexander.shalamov at gmail.com>
- Fixed Source/WebCore/ChangeLog.
- Added comment to LayoutTests/fast/media/media-query-invalid-value.html
- Fixed comment in Source/WebCore/css/CSSGrammar.y:538
- Fixed comment in Source/WebCore/css/MediaQueryEvaluator.cpp:252
- Fixed comment in Source/WebCore/css/MediaQueryEvaluator.cpp:257
- Refactored Source/WebCore/css/MediaQueryExp.cpp by moving checks from if()
statements.
- Added tests to fast/media/w3c/test_media_queries.html which verify that when
string value is 
  set to orientation or media feature that accepts length or number, media
query becomes invalid
  and serialized to "not all"
http://dev.w3.org/csswg/cssom/#serialize-a-media-query


More information about the webkit-reviews mailing list