[webkit-reviews] review granted: [Bug 97929] WebKit Doesn't Recognize Content-Language HTTP Header : [Attachment 168006] Patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Brian White
<bcwhite at chromium.org>'s request for review:
Bug 97929: WebKit Doesn't Recognize Content-Language HTTP Header
https://bugs.webkit.org/show_bug.cgi?id=97929

Attachment 168006: Patch
https://bugs.webkit.org/attachment.cgi?id=168006&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=168006&action=review


> Source/WebCore/loader/FrameLoader.cpp:673
> +	       if (commaIndex != notFound)

I don't think that this check is necessary - truncate will do nothing if the
index is outside bounds.

> LayoutTests/http/tests/misc/extract-http-content-language-malformed.php:20
> +  if (language == expect)
> +    element.innerText = 'Pass.  Got "' + expect + '" ' + msg + '.';
> +  else
> +    element.innerText = 'Fail!  Expected "' + expect + '" ' + msg + '; got
"' + language + '".';

This would be much better if existing testing support was used (shouldBe coming
from js-test-pre.js).