[webkit-reviews] review granted: [Bug 98892] HTMLTextFormControlElement calls setInlineStyleProperty with the wrong parameters. : [Attachment 167985] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 10 06:11:13 PDT 2012


jochen at chromium.org has granted Mike West <mkwst at chromium.org>'s request for
review:
Bug 98892: HTMLTextFormControlElement calls setInlineStyleProperty with the
wrong parameters.
https://bugs.webkit.org/show_bug.cgi?id=98892

Attachment 167985: Patch
https://bugs.webkit.org/attachment.cgi?id=167985&action=review

------- Additional Comments from jochen at chromium.org
View in context: https://bugs.webkit.org/attachment.cgi?id=167985&action=review


> Source/WebCore/html/HTMLTextFormControlElement.cpp:162
> +    placeholder->setInlineStyleProperty(CSSPropertyVisibility,
placeholderShouldBeVisible() ? "visible" : "hidden", false);

"important" defaults to false so you could also just omit it


More information about the webkit-reviews mailing list