[webkit-reviews] review granted: [Bug 98866] Add a test to check a step attribute works for a calendar picker : [Attachment 167939] Patch 2

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 10 00:04:45 PDT 2012


Yuta Kitamura <yutak at chromium.org> has granted Kent Tamura
<tkent at chromium.org>'s request for review:
Bug 98866: Add a test to check a step attribute works for a calendar picker
https://bugs.webkit.org/show_bug.cgi?id=98866

Attachment 167939: Patch 2
https://bugs.webkit.org/attachment.cgi?id=167939&action=review

------- Additional Comments from Yuta Kitamura <yutak at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=167939&action=review


Just have one comment. Looks good except for it. Please fix the issue before
landing.

>
LayoutTests/platform/chromium/fast/forms/calendar-picker/calendar-picker-appear
ance-step.html:9
> +    setTimeout(function() { testRunner.notifyDone(); }, 0);

I think this line can be simplified to:
    setTimeout(testRunner.notifyDone, 0);


More information about the webkit-reviews mailing list