[webkit-reviews] review granted: [Bug 98754] F4 key should open the picker popup on Windows : [Attachment 167922] Patch

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has granted Keishi Hattori
<keishi at webkit.org>'s request for review:
Bug 98754: F4 key should open the picker popup on Windows
https://bugs.webkit.org/show_bug.cgi?id=98754

Attachment 167922: Patch
https://bugs.webkit.org/attachment.cgi?id=167922&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=167922&action=review


> Source/WebCore/ChangeLog:27
> +	   * html/BaseMultipleFieldsDateAndTimeInputType.cpp:
> +	  
(WebCore::BaseMultipleFieldsDateAndTimeInputType::handleKeydownEvent):
> +	   * rendering/RenderTheme.cpp:
> +	   (WebCore::RenderTheme::shouldOpenPickerWithF4Key):
> +	   (WebCore):
> +	   * rendering/RenderTheme.h:
> +	   (RenderTheme):
> +	   * rendering/RenderThemeChromiumLinux.cpp:
> +	   (WebCore::RenderThemeChromiumLinux::shouldOpenPickerWithF4Key):
Returns true if we want to enable the F4 key binding on this platform.
> +	   (WebCore):
> +	   * rendering/RenderThemeChromiumLinux.h:
> +	   * rendering/RenderThemeChromiumWin.cpp:
> +	   (WebCore):
> +	   (WebCore::RenderThemeChromiumWin::shouldOpenPickerWithF4Key):
> +	   * rendering/RenderThemeChromiumWin.h:
> +	   (RenderThemeChromiumWin):

Please write per-file / per-function comments as possible