[webkit-reviews] review requested: [Bug 89344] [Chromium] Handle smaller sizes of media elements in Chromium video controls : [Attachment 167923] video controls adaptations via layout

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Oct 9 22:15:04 PDT 2012


Silvia Pfeiffer <silviapf at chromium.org> has asked  for review:
Bug 89344: [Chromium] Handle smaller sizes of media elements in Chromium video
controls
https://bugs.webkit.org/show_bug.cgi?id=89344

Attachment 167923: video controls adaptations via layout
https://bugs.webkit.org/attachment.cgi?id=167923&action=review

------- Additional Comments from Silvia Pfeiffer <silviapf at chromium.org>
Please review if layout()\(\) is the right approach, including for chldren of
enclosure. Also note that merging controls-video-sizes-padding0 and
controls-video-sizes-padding1 into one layout test will make the layout test
that DumpRenderTree runs right after it fail - a very curious bug that goes
away when running layout tests with --run-singly. Any pointers appreciated.


More information about the webkit-reviews mailing list