[webkit-reviews] review granted: [Bug 98432] [WebKit2] Create an API for adding and removing user stylesheets from a page group : [Attachment 167239] Patch

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has granted Andy Estes <aestes at apple.com>'s request
for review:
Bug 98432: [WebKit2] Create an API for adding and removing user stylesheets
from a page group
https://bugs.webkit.org/show_bug.cgi?id=98432

Attachment 167239: Patch
https://bugs.webkit.org/attachment.cgi?id=167239&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=167239&action=review


> Source/WebKit2/Shared/ImmutableArray.cpp:35
> +ImmutableArray::ImmutableArray(ImmutableArray::AdoptTag, APIObject**
entries, size_t size)

I think you can just call it AdoptTag here.

> Source/WebKit2/Shared/ImmutableArray.cpp:43
> +: m_entries(size)

Please indent.

> Source/WebKit2/Shared/UserContentContainer.cpp:89
> +	  
vector.uncheckedAppend(adoptRef(WebString::create(string).leakRef()));

Is the leakRef() adoptRef() craziness needed here?.  Could you not just do
vector.uncheckedAppend(WebString::create(string))?