[webkit-reviews] review denied: [Bug 98839] Store a visible rect in GraphicsLayers, and optionally dump it in layerTreeAsText : [Attachment 167890] Patch

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has denied Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 98839: Store a visible rect in GraphicsLayers, and optionally dump it in
layerTreeAsText
https://bugs.webkit.org/show_bug.cgi?id=98839

Attachment 167890: Patch
https://bugs.webkit.org/attachment.cgi?id=167890&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=167890&action=review


Looks good, but more things need to build.

> Source/WebCore/platform/graphics/GraphicsLayer.cpp:695
> +    WTF::String output = layer->layerTreeAsText(LayerTreeAsTextDebug |
LayerTreeAsTextIncludeVisibleRects);

Not new, but the WTF:: here is not necessary.

> Source/WebCore/platform/graphics/GraphicsLayer.h:439
> +    static void writeIndent(TextStream&, int /*indent*/);

There is no reason to comment out the word indent here.