[webkit-reviews] review denied: [Bug 98754] F4 key should open the picker popup on Windows : [Attachment 167894] removed extra {

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has denied Keishi Hattori
<keishi at webkit.org>'s request for review:
Bug 98754: F4 key should open the picker popup on Windows
https://bugs.webkit.org/show_bug.cgi?id=98754

Attachment 167894: removed extra {
https://bugs.webkit.org/attachment.cgi?id=167894&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=167894&action=review


> Source/WebCore/html/BaseMultipleFieldsDateAndTimeInputType.cpp:197
> +    } else if (m_pickerIndicatorIsVisible && event->keyIdentifier() ==
"Down" && event->getModifierState("Alt")) {
>	   m_pickerIndicatorElement->openPopup();

Should we check nullness of m_pickerIndicatorElement here too?

> Source/WebCore/rendering/RenderThemeChromiumWin.cpp:814
> +    return true;

We apply the same key bindings to Chromium-Windows and Chromium-Linux.	Please
add this function to RenderThemeChromiumLinux too.