[webkit-reviews] review granted: [Bug 85326] WebIDL: overloaded methods prevent number -> string conversion : [Attachment 167870] Patch

[bugzilla-daemon at webkit.org]

Kentaro Hara <haraken at chromium.org> has granted Joshua Bell
<jsbell at chromium.org>'s request for review:
Bug 85326: WebIDL: overloaded methods prevent number -> string conversion
https://bugs.webkit.org/show_bug.cgi?id=85326

Attachment 167870: Patch
https://bugs.webkit.org/attachment.cgi?id=167870&action=review

------- Additional Comments from Kentaro Hara <haraken at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=167870&action=review


> Source/WebCore/ChangeLog:11
> +	   Enable legacy behavior of only matching
undefined/null/string/object(and not number,
> +	   boolean, etc) via the StrictTypeChecking attribute.

Ideally we want to kill the legacy behavior, but it looks reasonable to land
this patch first.

> Source/WebCore/Modules/indexeddb/IDBCursor.cpp:303
> +    // FIXME: Remove legacy constants. http://webkit.org/b/85315

Nit: Also let's add "this is not thread-safe".

> Source/WebCore/Modules/indexeddb/IDBTransaction.cpp:344
> +    // FIXME: Remove legacy constants. http://webkit.org/b/85315

Ditto.