[webkit-reviews] review granted: [Bug 98470] [WebGL] [Mac] queried attributes and uniforms need to return the original variable name (not the mapped name) : [Attachment 167851] Patch

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has granted Roger Fong <roger_fong at apple.com>'s
request for review:
Bug 98470: [WebGL] [Mac] queried attributes and uniforms need to return the
original variable name (not the mapped name)
https://bugs.webkit.org/show_bug.cgi?id=98470

Attachment 167851: Patch
https://bugs.webkit.org/attachment.cgi?id=167851&action=review

------- Additional Comments from Dean Jackson <dino at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=167851&action=review


> Source/WebCore/ChangeLog:7
> +	   Reviewed by NOBODY (OOPS!).
> +

I usually write a paragraph here saying what I did (although the title is
pretty obvious in this case). For example "When a variable name in a shader is
long, we translate it into a short form and keep a mapping between the new and
old names. However, we were accidentally telling the client-side code the
translated name. It should always use the original names"

> Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:635

> +    String origName = originalSymbolName(program,
SHADER_SYMBOL_TYPE_ATTRIBUTE, String(name.get(), nameLength));
> +    
> +    info.name = origName;

Use long names in variables: originalName

> Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:662

> +    String origName = originalSymbolName(program,
SHADER_SYMBOL_TYPE_UNIFORM, String(name.get(), nameLength));
> +    
> +    info.name = origName;

Ditto.