[webkit-reviews] review granted: [Bug 97689] [chromium][Android] Add WebSecurityOrigin::grantLoadLocalResources() : [Attachment 167787] patch.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Oct 9 14:11:26 PDT 2012


Adam Barth <abarth at webkit.org> has granted Ben Murdoch <benm at google.com>'s
request for review:
Bug 97689: [chromium][Android] Add WebSecurityOrigin::grantLoadLocalResources()
https://bugs.webkit.org/show_bug.cgi?id=97689

Attachment 167787: patch.
https://bugs.webkit.org/attachment.cgi?id=167787&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=167787&action=review


> Source/WebCore/page/SecurityOrigin.cpp:433
>      // To be backwards compatible with older versions of WebKit, we also use

>      // this function to grant the ability to load local resources to
documents
>      // loaded with SubstituteData.

This part of the comment is outdated and should be removed.

> Source/WebKit/chromium/public/WebSecurityOrigin.h:100
> +    // Allows this WebSecurityOrigin access to local resources.
> +    WEBKIT_EXPORT void grantLoadLocalResources() const;

I have some reservations about exposing this API since its easy to use it in an
insecure way, but I guess we'll just need to be careful.


More information about the webkit-reviews mailing list