[webkit-reviews] review denied: [Bug 98789] [GTK] Plugin don't display : [Attachment 167828] Patch

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has denied Daniel Drake
<dsd at laptop.org>'s request for review:
Bug 98789: [GTK] Plugin don't display
https://bugs.webkit.org/show_bug.cgi?id=98789

Attachment 167828: Patch
https://bugs.webkit.org/attachment.cgi?id=167828&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=167828&action=review


> Source/WebKit/gtk/webkit/webkitwebview.cpp:-875
> -    gtk_widget_get_allocation(widget, &oldAllocation);
> -
>      GTK_WIDGET_CLASS(webkit_web_view_parent_class)->size_allocate(widget,
allocation);
> -    if (allocation->width == oldAllocation.width && allocation->height ==
oldAllocation.height)
> -	   return;

I think this is the wrong fix. Instead of simply ignoring whether or not the
size has changed, you should pass the information to
resizeWebViewFromAllocation and only keep the call to
gtk_container_forall(GTK_CONTAINER(webView),
updateChildAllocationFromPendingAllocation, 0); when the size hasn't changed.
Please see the WebKitWebViewBase for an example.