[webkit-reviews] review denied: [Bug 98545] [chromium] fast/text/international/text-spliced-font.html and fast/writing-mode/Kusa-Makura-background-canvas.html failing on the Mac after r130443 : [Attachment 167781] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Oct 9 11:54:32 PDT 2012
Tony Chang <tony at chromium.org> has denied review:
Bug 98545: [chromium] fast/text/international/text-spliced-font.html and
fast/writing-mode/Kusa-Makura-background-canvas.html failing on the Mac after
r130443
https://bugs.webkit.org/show_bug.cgi?id=98545
Attachment 167781: Patch
https://bugs.webkit.org/attachment.cgi?id=167781&action=review
------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=167781&action=review
> Source/WebCore/platform/graphics/FontFastPath.cpp:228
> + if (isCJKIdeographOrSymbol(c) &&
data.fontData->platformData().orientation() != Horizontal &&
!data.fontData->isTextOrientationFallback())
Sorry, this is backwards. It should be !isCJKIdeographOrSymbol(c)
More information about the webkit-reviews
mailing list