[webkit-reviews] review denied: [Bug 98660] RenderBoxModelObject::paintTranslucentBorderSides() creates needless transparency layers : [Attachment 167776] After out-of-band review, moving the implementation back to paintTranslucentBorderSides(), but reversing the flag-application logic for reasability

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Oct 9 10:31:52 PDT 2012


Simon Fraser (smfr) <simon.fraser at apple.com> has denied Tom Hudson
<tomhudson at google.com>'s request for review:
Bug 98660: RenderBoxModelObject::paintTranslucentBorderSides() creates needless
transparency layers
https://bugs.webkit.org/show_bug.cgi?id=98660

Attachment 167776: After out-of-band review, moving the implementation back to
paintTranslucentBorderSides(), but reversing the flag-application logic for
reasability
https://bugs.webkit.org/attachment.cgi?id=167776&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
I think it would be slightly better for RenderBoxModelObject::paintBorder() to
compute edgesToDraw in its existing loop through the edges. edgesToDraw could
then be passed to paintTranslucentBorderSides() and paintBorderSides().


More information about the webkit-reviews mailing list