[webkit-reviews] review denied: [Bug 98737] Change allowRoudingHack with setAllowRoudingHack : [Attachment 167723] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has denied Gyuyoung Kim
<gyuyoung.kim at samsung.com>'s request for review:
Bug 98737: Change allowRoudingHack with setAllowRoudingHack
https://bugs.webkit.org/show_bug.cgi?id=98737

Attachment 167723: Patch
https://bugs.webkit.org/attachment.cgi?id=167723&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=167723&action=review


> Source/WebCore/testing/InternalSettings.idl:77
> -	   void allowRoundingHacks();
> +	   void setAllowRoundingHacks(in boolean allowed);

I think this should be called some thing like "setAllowTextRounding()" or
something. The term "hacks" isn't useful here, and it need some context that
suggests that it applies to text. Looking at TextRun, it appears to affect word
and text run rounding.