[webkit-reviews] review denied: [Bug 98721] [WebSocket] Use CString for parsed value of Sec-WebSocket-Extensions : [Attachment 167693] Patch

[bugzilla-daemon at webkit.org]

Yuta Kitamura <yutak at chromium.org> has denied Kenichi Ishibashi
<bashi at chromium.org>'s request for review:
Bug 98721: [WebSocket] Use CString for parsed value of Sec-WebSocket-Extensions
https://bugs.webkit.org/show_bug.cgi?id=98721

Attachment 167693: Patch
https://bugs.webkit.org/attachment.cgi?id=167693&action=review

------- Additional Comments from Yuta Kitamura <yutak at chromium.org>
It's unlikely for future WebSocket extensions to require putting binary data
within a quoted-string, so I don't think this
change is worthwhile.

I think you just need to validate the content of a quoted-string and fail the
connection if it is broken. You may even assume
a quoted-string only contains ASCII characters (not UTF-8), if that simplify
things. There's no known WebSocket
extension that requires non-ASCII data, and there won't be any, I guess.