[webkit-reviews] review granted: [Bug 98726] [EFL][EWebLauncher] Add encoding detector option. : [Attachment 167698] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Oct 9 01:21:12 PDT 2012


Gyuyoung Kim <gyuyoung.kim at samsung.com> has granted Kangil Han
<kangil.han at samsung.com>'s request for review:
Bug 98726: [EFL][EWebLauncher] Add encoding detector option.
https://bugs.webkit.org/show_bug.cgi?id=98726

Attachment 167698: patch
https://bugs.webkit.org/attachment.cgi?id=167698&action=review

------- Additional Comments from Gyuyoung Kim <gyuyoung.kim at samsung.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=167698&action=review


> Tools/EWebLauncher/main.c:151
> +    Eina_Bool enableEncodingDetector;

Alphabetical order ?

> Tools/EWebLauncher/main.c:917
> +    userArgs->enableEncodingDetector = EINA_FALSE;

ditto ?

> Tools/EWebLauncher/main.c:931
> +	   ECORE_GETOPT_VALUE_BOOL(userArgs->enableEncodingDetector),

ditto ?


More information about the webkit-reviews mailing list