[webkit-reviews] review granted: [Bug 98499] Page popup should be smarter about its layout : [Attachment 167703] Patch

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has granted Keishi Hattori
<keishi at webkit.org>'s request for review:
Bug 98499: Page popup should be smarter about its layout
https://bugs.webkit.org/show_bug.cgi?id=98499

Attachment 167703: Patch
https://bugs.webkit.org/attachment.cgi?id=167703&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=167703&action=review


> Source/WebCore/Resources/pagepopups/pickerCommon.js:114
> +	   availRect = Rect.intersection(availRect, rootViewRect);

Null dereference would happen if Rect.intersection returns null.
Probably it never happens, but we had better set something non-null to
availRect just in case.