[webkit-reviews] review denied: [Bug 93958] Pageload tests should measure memory usage : [Attachment 167662] proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Oct 8 18:21:52 PDT 2012


Ryosuke Niwa <rniwa at webkit.org> has denied Zoltan Horvath <zoltan at webkit.org>'s
request for review:
Bug 93958: Pageload tests should measure memory usage
https://bugs.webkit.org/show_bug.cgi?id=93958

Attachment 167662: proposed patch
https://bugs.webkit.org/attachment.cgi?id=167662&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=167662&action=review


We need Python tests for this.

> Tools/Scripts/webkitpy/performance_tests/perftest.py:241
> +	   results[self.test_name() + ' unit'] = 'ms'

!? This should be results[self.test_name()]['unit'] = 'ms' instead.

> Tools/Scripts/webkitpy/performance_tests/perftest.py:256
> +		   results.setdefault(name, [])
> +		   results[name].append(result)

This isn't right. results[name] should be a dictionary, not a list.


More information about the webkit-reviews mailing list