[webkit-reviews] review denied: [Bug 98694] [Performance] Speed-up DOM tree traversal on ARM platforms : [Attachment 167661] Proposed patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Oct 8 18:15:42 PDT 2012
Benjamin Poulain <benjamin at webkit.org> has denied Kulanthaivel Palanichamy
<kulanthaivel at codeaurora.org>'s request for review:
Bug 98694: [Performance] Speed-up DOM tree traversal on ARM platforms
https://bugs.webkit.org/show_bug.cgi?id=98694
Attachment 167661: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=167661&action=review
------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
We need a much refine performance claim to use anything like this. The problem
with prefetch is it varies with the architecture, and on ARM, with the
implementation of the architecture.
Please:
1) Get solid performance number, use microbenchmarks if needed.
2) Include the performance analysis in the ChangeLog.
3) Test on various CPU if you have access to them.
More information about the webkit-reviews
mailing list