[webkit-reviews] review requested: [Bug 50000] [Qt] Remove redundant JAVASCRIPTCORE_JIT variable : [Attachment 167612] proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Oct 8 14:32:58 PDT 2012


Laszlo Gombos <laszlo.gombos at webkit.org> has asked  for review:
Bug 50000: [Qt] Remove redundant JAVASCRIPTCORE_JIT variable
https://bugs.webkit.org/show_bug.cgi?id=50000

Attachment 167612: proposed patch
https://bugs.webkit.org/attachment.cgi?id=167612&action=review

------- Additional Comments from Laszlo Gombos <laszlo.gombos at webkit.org>
As Simon indicated valgrind might work with JIT enabled. Potentially in
valgrind.prf the following line would make more sense

-DEFINES += ENABLE_JIT=0
+enable?(jit): DEFINES += ENABLE_JIT=0

I am happy to make that change or perhaps it could be in a follow-up patch.


More information about the webkit-reviews mailing list