[webkit-reviews] review canceled: [Bug 98677] Replace 2 uses of updateLogicalHeight with computeLogicalHeight : [Attachment 167576] Patch

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has canceled  review:
Bug 98677: Replace 2 uses of updateLogicalHeight with computeLogicalHeight
https://bugs.webkit.org/show_bug.cgi?id=98677

Attachment 167576: Patch
https://bugs.webkit.org/attachment.cgi?id=167576&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=167576&action=review


>> Source/WebCore/rendering/svg/RenderSVGForeignObject.cpp:115
>> +void RenderSVGForeignObject::computeLogicalHeight(LayoutUnit, LayoutUnit
logicalTop, LogicalExtentComputedValues& computedValues) const
> 
> I assume foreignObject is forced into horizontal-tb?
> 
> Not really related to this patch, but I feel like we should have asserts at
the top of all the layout/computeLogicalHeight/computeLogicalWidth methods for
RenderObject subclasses that don't support vertical writing mode. Either that,
or a FIXME to support it.

Oh, no, they're not forced into horizontal-tb.	Let me see if I can make a test
case for that.