[webkit-reviews] review granted: [Bug 98677] Replace 2 uses of updateLogicalHeight with computeLogicalHeight : [Attachment 167576] Patch

[bugzilla-daemon at webkit.org]

Ojan Vafai <ojan at chromium.org> has granted Tony Chang <tony at chromium.org>'s
request for review:
Bug 98677: Replace 2 uses of updateLogicalHeight with computeLogicalHeight
https://bugs.webkit.org/show_bug.cgi?id=98677

Attachment 167576: Patch
https://bugs.webkit.org/attachment.cgi?id=167576&action=review

------- Additional Comments from Ojan Vafai <ojan at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=167576&action=review


> Source/WebCore/rendering/svg/RenderSVGForeignObject.cpp:115
> +void RenderSVGForeignObject::computeLogicalHeight(LayoutUnit, LayoutUnit
logicalTop, LogicalExtentComputedValues& computedValues) const

I assume foreignObject is forced into horizontal-tb?

Not really related to this patch, but I feel like we should have asserts at the
top of all the layout/computeLogicalHeight/computeLogicalWidth methods for
RenderObject subclasses that don't support vertical writing mode. Either that,
or a FIXME to support it.