[webkit-reviews] review granted: [Bug 98562] nrwt: [chromium] run http tests in parallel on bigger machines : [Attachment 167396] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Dirk Pranke <dpranke at chromium.org>'s
request for review:
Bug 98562: nrwt: [chromium] run http tests in parallel on bigger machines
https://bugs.webkit.org/show_bug.cgi?id=98562

Attachment 167396: Patch
https://bugs.webkit.org/attachment.cgi?id=167396&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=167396&action=review


LGTM.

> Tools/Scripts/webkitpy/layout_tests/port/chromium.py:120
> +    def default_max_locked_shards(self):
> +	   """Return the number of "locked" shards to run in parallel (like the
http tests)."""
> +	   max_locked_shards = int(self.default_child_processes()) / 4
> +	   if not max_locked_shards:
> +	       return 1
> +	   return max_locked_shards

I assume the plan is to move this logic down once tested in the field?