[webkit-reviews] review granted: [Bug 98574] Some GraphicsLayer cleanup to separate the concepts of using a tile cache, and being the main tile cache layer : [Attachment 167429] Patch

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 98574: Some GraphicsLayer cleanup to separate the concepts of using a tile
cache, and being the main tile cache layer
https://bugs.webkit.org/show_bug.cgi?id=98574

Attachment 167429: Patch
https://bugs.webkit.org/attachment.cgi?id=167429&action=review

------- Additional Comments from Dean Jackson <dino at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=167429&action=review


> Source/WebCore/platform/graphics/GraphicsLayer.cpp:341
> +void GraphicsLayer::debugBorderInfo(Color& color, float& width) const

In a recent review from Darin, he said "We reserve the word 'get' for functions
that have no return value and use out arguments instead". When I was seeing
this used in action below, it wasn't clear the function was doing anything
since you don't get return values. Maybe it should be getDebugBorderInfo?

> Source/WebCore/platform/graphics/GraphicsLayer.cpp:373
> +    Color borderColor;
> +    float width = 0;
> +    debugBorderInfo(borderColor, width);
> +    setDebugBorder(borderColor, width);

Here's the place I was talking about above.

> Source/WebCore/platform/graphics/ca/win/PlatformCALayerWinInternal.cpp:99
> -    if (owner()->owner()->platformCALayerShowRepaintCounter()) {
> +    if (owner()->owner()->platformCALayerShowRepaintCounter(owner())) {

wow.