[webkit-reviews] review granted: [Bug 98455] max-width property is does not overriding the width properties for css tables(display:table) : [Attachment 167194] Patch

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has granted Pravin D <pravind.2k4 at gmail.com>'s
request for review:
Bug 98455: max-width property is does not overriding the width properties for
css tables(display:table)
https://bugs.webkit.org/show_bug.cgi?id=98455

Attachment 167194: Patch
https://bugs.webkit.org/attachment.cgi?id=167194&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=167194&action=review


Julien may have additional comments.

> Source/WebCore/rendering/RenderTable.cpp:266
> +    if (styleMaxLogicalWidth.isSpecified() &&
styleMaxLogicalWidth.isPositive())

0 should be a valid value for max-width.  I think you want
!styleMaxLogicalWidth.isNegative().  Maybe add a test case for this?

> Source/WebCore/rendering/RenderTable.cpp:269
> +    setLogicalWidth(max<int>(computedMinLogicalWidth, min(logicalWidth(),
computedMaxLogicalWidth)));

The mixing of max (template) and min (no-template) styles is weird, but maybe
it's intentional to do the conversion to int at the last moment?