[webkit-reviews] review granted: [Bug 89250] [chromium] Make sure events are transformed correctly for plugins. : [Attachment 167421] Patch

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has granted sadrul at chromium.org's request for
review:
Bug 89250: [chromium] Make sure events are transformed correctly for plugins.
https://bugs.webkit.org/show_bug.cgi?id=89250

Attachment 167421: Patch
https://bugs.webkit.org/attachment.cgi?id=167421&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=167421&action=review


> Source/WebKit/chromium/src/WebInputEventConversion.cpp:405
> +static void updateWebMouseEventFromWebCoreMouseEvent(const MouseEvent&
event, const Widget& widget, const WebCore::RenderObject& renderObject,
WebMouseEvent& webEvent)

Nit: I would have kept Widget and RenderObject as pointers, but this is OK.

> LayoutTests/platform/chromium/plugins/transformed-events.html:40
> +	   // Test gesture events.
> +	   eventSender.gestureTapDown(positionX, positionY);
> +	   eventSender.gestureTap(positionX, positionY);

Can you add tests for scroll events too?  You said they're also not translating
the points properly?