[webkit-reviews] review granted: [Bug 98649] [EFL][WK2] Add support for window.create in Minibrowser : [Attachment 167536] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Oct 8 08:17:11 PDT 2012


Kenneth Rohde Christiansen <kenneth at webkit.org> has granted Christophe Dumez
<christophe.dumez at intel.com>'s request for review:
Bug 98649: [EFL][WK2] Add support for window.create in Minibrowser
https://bugs.webkit.org/show_bug.cgi?id=98649

Attachment 167536: Patch
https://bugs.webkit.org/attachment.cgi?id=167536&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=167536&action=review


> Tools/MiniBrowser/efl/main.c:226
> +    Browser_Window *window = window_create(NULL, EINA_FALSE);

shouldnt it inherit the flattening? anyway I guess that should be fixed
differently because it is quite ugly to pass around like this


More information about the webkit-reviews mailing list