[webkit-reviews] review denied: [Bug 98629] [Chromium]Android content shell debug build warning for uninitialized value used as error : [Attachment 167509] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Oct 7 23:02:39 PDT 2012


Benjamin Poulain <benjamin at webkit.org> has denied Wei James (wistoch)
<james.wei at intel.com>'s request for review:
Bug 98629: [Chromium]Android content shell debug build warning for
uninitialized value used as error
https://bugs.webkit.org/show_bug.cgi?id=98629

Attachment 167509: Patch
https://bugs.webkit.org/attachment.cgi?id=167509&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
memset is a bad idea performance wise for small data structures.

I also don't see why this needs to be initialized outside it's trait's
constructDeletedValue. Zeroing memory is not free.


More information about the webkit-reviews mailing list