[webkit-reviews] review denied: [Bug 98624] Null-check for DOMWindow before feeding it to FeatureObserver. : [Attachment 167489] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has denied Mike West <mkwst at chromium.org>'s
request for review:
Bug 98624: Null-check for DOMWindow before feeding it to FeatureObserver.
https://bugs.webkit.org/show_bug.cgi?id=98624

Attachment 167489: Patch
https://bugs.webkit.org/attachment.cgi?id=167489&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=167489&action=review


> Source/WebCore/page/FeatureObserver.cpp:58
> +    if (!domWindow)
> +	   return;

Presumably we don't need this null check in both places.  It's better to have
it in ContentSecurityPolicy.cpp since most callers will already know that the
DOMWindow is non-0.