[webkit-reviews] review granted: [Bug 98602] webkitpy: Pass the `Listen' Apache directive from Apache, not the httpd.conf files. : [Attachment 167459] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Oct 6 15:38:26 PDT 2012


Eric Seidel <eric at webkit.org> has granted Raphael Kubo da Costa (rakuco)
<rakuco at webkit.org>'s request for review:
Bug 98602: webkitpy: Pass the `Listen' Apache directive from Apache, not the
httpd.conf files.
https://bugs.webkit.org/show_bug.cgi?id=98602

Attachment 167459: Patch
https://bugs.webkit.org/attachment.cgi?id=167459&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=167459&action=review


Sounds like a great win!

> Tools/Scripts/webkitpy/layout_tests/port/base.py:930
> +	   return socket.has_ipv6

Is it safe to assume that if python will have ipv6 if and only if apache does?


More information about the webkit-reviews mailing list