[webkit-reviews] review granted: [Bug 98567] [V8] toV8(Node*, ...) does more work than needed (6% faster on dom-traverse) : [Attachment 167406] Patch

[bugzilla-daemon at webkit.org]

Kentaro Hara <haraken at chromium.org> has granted Adam Barth
<abarth at webkit.org>'s request for review:
Bug 98567: [V8] toV8(Node*, ...) does more work than needed (6% faster on
dom-traverse)
https://bugs.webkit.org/show_bug.cgi?id=98567

Attachment 167406: Patch
https://bugs.webkit.org/attachment.cgi?id=167406&action=review

------- Additional Comments from Kentaro Hara <haraken at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=167406&action=review


Awesome!

> Source/WebCore/bindings/scripts/CodeGeneratorV8.pm:534
> +    if (holder->wrapper() && *holder->wrapper() == holderWrapper &&
node->wrapper())

This looks a bit hacky. Shall we add a comment on this?

> Source/WebCore/bindings/scripts/CodeGeneratorV8.pm:535
> +	   return *node->wrapper();

Maybe you can now remove the logic to check node->wrapper() from
V8DOMWrapper::getCachedWrapper()? (You can do it in a follow-up patch.)