[webkit-reviews] review canceled: [Bug 97800] Allow ports to override text track rendering style : [Attachment 167190] Patch

[bugzilla-daemon at webkit.org]

Julien Chaffraix <jchaffraix at webkit.org> has canceled  review:
Bug 97800: Allow ports to override text track rendering style
https://bugs.webkit.org/show_bug.cgi?id=97800

Attachment 167190: Patch
https://bugs.webkit.org/attachment.cgi?id=167190&action=review

------- Additional Comments from Julien Chaffraix <jchaffraix at webkit.org>
Looks like this change broke several platforms (not sure why none of the bots
complained):

* Most Mac ones (andersca fixed them in
http://trac.webkit.org/changeset/130564)
* Windows, here is the warning:

26>..\..\WebCore\rendering\RenderTheme.h(239): error C2220: warning treated as
error - no 'object' file generated
26>..\..\WebCore\rendering\RenderTheme.h(239): warning C4305: 'return' :
truncation from 'double' to 'float'

This comes from this line:

virtual float captionFontSizeScale() const { return 0.05; }

Mostly the patch was landed with an r+ from a non-reviewer which was the reason
for rolling out instead of fixing the build.