[webkit-reviews] review requested: [Bug 97569] Assertion failure in non-JIT'ed LLInt on ARM Thumb : [Attachment 167385] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Oct 5 14:47:41 PDT 2012


Cosmin Truta <ctruta at gmail.com> has asked  for review:
Bug 97569: Assertion failure in non-JIT'ed LLInt on ARM Thumb
https://bugs.webkit.org/show_bug.cgi?id=97569

Attachment 167385: Patch
https://bugs.webkit.org/attachment.cgi?id=167385&action=review

------- Additional Comments from Cosmin Truta <ctruta at gmail.com>
Since createFromExecutableAddress takes pointers from LLInt::getCodePtr() only,
I think this the best place to isolate disabling the check for decorated code
pointers.
(ASSERT_VALID_CODE_POINTER has also failed in other places on our machines, but
we were able to resolve those failures without having to disable the decorated
pointer check globally.)


More information about the webkit-reviews mailing list