[webkit-reviews] review granted: [Bug 98522] No autorelease pool in place, causing buildup of autoreleased objects. : [Attachment 167332] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Oct 5 10:42:05 PDT 2012


Alexey Proskuryakov <ap at webkit.org> has granted Jer Noble
<jer.noble at apple.com>'s request for review:
Bug 98522: No autorelease pool in place, causing buildup of autoreleased
objects.
https://bugs.webkit.org/show_bug.cgi?id=98522

Attachment 167332: Patch
https://bugs.webkit.org/attachment.cgi?id=167332&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=167332&action=review


> Source/WebCore/ChangeLog:4
> +	   https://bugs.webkit.org/show_bug.cgi?id=98522

If there is a Radar bug tracking this, please post its number to Bugzilla and
to ChangeLog.

> Source/WebCore/platform/cf/RunLoopTimerCF.cpp:49
> +    AutodrainedPool pool;

This won't break Windows build, will it? With a cursory look, I couldn't find a
no-op implementation of this class that Windows could be using.


More information about the webkit-reviews mailing list