[webkit-reviews] review granted: [Bug 98518] [Qt][WK2] Plugins are completely broken with a custom device pixel ratio : [Attachment 167326] Patch

[bugzilla-daemon at webkit.org]

Kenneth Rohde Christiansen <kenneth at webkit.org> has granted Balazs Kelemen
<kbalazs at webkit.org>'s request for review:
Bug 98518: [Qt][WK2] Plugins are completely broken with a custom device pixel
ratio
https://bugs.webkit.org/show_bug.cgi?id=98518

Attachment 167326: Patch
https://bugs.webkit.org/attachment.cgi?id=167326&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=167326&action=review


>>> Source/WebKit2/Shared/qt/ShareableBitmapQt.cpp:91
>>> +	 painter->restore();
>> 
>> why not do a fast path for  scaleFactor == 1.0?
> 
> It's already there :) (above the changed lines)

Is it possible somehow to use the GraphicsContext3D to use the hardware for
scaling? iguess you are basically scaling an image right?