[webkit-reviews] review denied: [Bug 96990] Make ContentSelectorQuery work when parent and children are passed explicitly. : [Attachment 167256] Rebase
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Oct 5 09:21:37 PDT 2012
Dimitri Glazkov (Google) <dglazkov at chromium.org> has denied Hayato Ito
<hayato at chromium.org>'s request for review:
Bug 96990: Make ContentSelectorQuery work when parent and children are passed
explicitly.
https://bugs.webkit.org/show_bug.cgi?id=96990
Attachment 167256: Rebase
https://bugs.webkit.org/attachment.cgi?id=167256&action=review
------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
OMG, this patch is so tremendously ugly, I want to cry. The adding of the base
class (!!!) for a simple struct like SelectorCheckingContext, the slopping
around of the shadow DOM-specific logic in SelectorChecker, the extra
dependencies of headers from html/shadow.. Ugh.
Folks, we _must_ find a better way. We can't land this. I'll help you next
week.
More information about the webkit-reviews
mailing list