[webkit-reviews] review granted: [Bug 98244] [Refactoring] Scoped Style related code should have its own class. : [Attachment 167296] I'm back

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Oct 5 09:09:19 PDT 2012


Dimitri Glazkov (Google) <dglazkov at chromium.org> has granted Hajime Morrita
<morrita at google.com>'s request for review:
Bug 98244: [Refactoring] Scoped Style related code should have its own class.
https://bugs.webkit.org/show_bug.cgi?id=98244

Attachment 167296: I'm back
https://bugs.webkit.org/attachment.cgi?id=167296&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=167296&action=review


This is great. Please make the bubbles happy before landing.

> Source/WebCore/css/StyleResolver.h:489
> +    OwnPtr<StyleScopeResolver> m_scoper;

Who u callin scoper? http://www.urbandictionary.com/define.php?term=Scoper

Maybe m_scopeResolver would be better :)


More information about the webkit-reviews mailing list