[webkit-reviews] review granted: [Bug 77921] [GTK] Add support for creating EGL contexts : [Attachment 167324] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Oct 5 07:54:43 PDT 2012
Martin Robinson <mrobinson at webkit.org> has granted José Dapena Paz
<jdapena at igalia.com>'s request for review:
Bug 77921: [GTK] Add support for creating EGL contexts
https://bugs.webkit.org/show_bug.cgi?id=77921
Attachment 167324: Patch
https://bugs.webkit.org/attachment.cgi?id=167324&action=review
------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=167324&action=review
Looks good, but a few minor nits. I'll fix them and land this patch.
> Source/WebCore/platform/graphics/cairo/GraphicsContext3DCairo.cpp:49
> +#include "OpenGLShims.h"
Maybe we can omit this since we don't need access to redefinitions of common
functionality.
> Source/WebCore/platform/graphics/cairo/GraphicsContext3DPrivate.cpp:135
> + ::glBindFramebufferEXT(GraphicsContext3D::FRAMEBUFFER,
m_context->m_boundFBO);
Can't we go the other way here and leave glBindFramebuffer?
> Source/WebCore/platform/graphics/egl/GLContextEGL.cpp:208
> + : GLContext()
The compiler should automatically call the default constructor.
> Source/WebCore/platform/graphics/glx/GLContextGLX.cpp:166
> + : GLContext()
Ditto.
> Source/WebCore/platform/graphics/glx/GLContextGLX.cpp:176
> + : GLContext()
Ditto.
More information about the webkit-reviews
mailing list