[webkit-reviews] review granted: [Bug 98268] [Qt] Make RenderThemeQStyle/ScrollbarThemeQStyle compile without QStyle/QtWidgets : [Attachment 167088] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Oct 5 04:20:52 PDT 2012


Tor Arne Vestbø <vestbo at webkit.org> has granted Simon Hausmann
<hausmann at webkit.org>'s request for review:
Bug 98268: [Qt] Make RenderThemeQStyle/ScrollbarThemeQStyle compile without
QStyle/QtWidgets
https://bugs.webkit.org/show_bug.cgi?id=98268

Attachment 167088: Patch
https://bugs.webkit.org/attachment.cgi?id=167088&action=review

------- Additional Comments from Tor Arne Vestbø <vestbo at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=167088&action=review


r=me

>> Source/WebKit/qt/WebCoreSupport/QStyleFacadeImp.cpp:256
>> +	   style()->drawControl(QStyle::CE_RadioButton, &option, painter,
widget);
> 
> Weird number of spaces at line-start.  Are you using a 4-space indent? 
[whitespace/indent] [3]

nitpick before landing


More information about the webkit-reviews mailing list