[webkit-reviews] review granted: [Bug 97800] Allow ports to override text track rendering style : [Attachment 167190] Patch

[bugzilla-daemon at webkit.org]

Silvia Pfeiffer <silviapf at chromium.org> has granted Jer Noble
<jer.noble at apple.com>'s request for review:
Bug 97800: Allow ports to override text track rendering style
https://bugs.webkit.org/show_bug.cgi?id=97800

Attachment 167190: Patch
https://bugs.webkit.org/attachment.cgi?id=167190&action=review

------- Additional Comments from Silvia Pfeiffer <silviapf at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=167190&action=review


> Source/WebKit/mac/ChangeLog:25
> +2012-10-04  Eric Carlson  <eric.carlson at apple.com>
> +
> +	   Allow ports to override text track rendering style
> +	   https://bugs.webkit.org/show_bug.cgi?id=97800
> +	   <rdar://problem/12044964>
> +
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	   Additional information of the change such as approach, rationale.
Please add per-function descriptions below (OOPS!).
> +
> +	   * WebCoreSupport/WebSystemInterface.mm:
> +	   (InitWebCoreSystemInterface): Initialize new WKSI function pointers.

> +
> +2012-09-27  Eric Carlson  <eric.carlson at apple.com>
> +
> +	   Need a short description (OOPS!).
> +	   Need the bug URL (OOPS!).
> +
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	   Additional information of the change such as approach, rationale.
Please add per-function descriptions below (OOPS!).
> +
> +	   * WebCoreSupport/WebSystemInterface.mm:
> +	   (InitWebCoreSystemInterface):
> +

Two entries? You might want to clean up this ChangeLog.

> Source/WebCore/html/HTMLMediaElement.cpp:3999
>	   configureTextTracks();

You  might want to remove this, since
markCaptionAndSubtitleTracksAsUnconfigured is already doing this as its last
action.