[webkit-reviews] review granted: [Bug 98452] Font::glyphDataAndPageForCharacter doesn't account for text orientation when using systemFallback on a cold cache. : [Attachment 167197] Patch

[bugzilla-daemon at webkit.org]

mitz at webkit.org <mitz at webkit.org> has granted Enrica Casucci
<enrica at apple.com>'s request for review:
Bug 98452: Font::glyphDataAndPageForCharacter doesn't account for text
orientation when using systemFallback on a cold cache.
https://bugs.webkit.org/show_bug.cgi?id=98452

Attachment 167197: Patch
https://bugs.webkit.org/attachment.cgi?id=167197&action=review

------- Additional Comments from mitz at webkit.org <mitz at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=167197&action=review


> Source/WebCore/platform/graphics/FontFastPath.cpp:50
> +static inline std::pair<GlyphData, GlyphPage*>
applyTextOrientationForCharacter(UChar32 c, GlyphData& data, GlyphPage* page,
unsigned pageNumber, TextOrientation orientation)

Please rename “c” to “character”. The verb “apply” doesn’t fit a function that
doesn’t mutate anything. How about
glyphDataAndPageForCharacterWithTextOrientation(…), perhaps also moving the
TextOrientation parameter to the second spot?