[webkit-reviews] review denied: [Bug 91228] imagemap without a "name" attribute doesn't work (affects xkcd.com) : [Attachment 167178] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Oct 4 15:32:14 PDT 2012
Sam Weinig <sam at webkit.org> has denied Akash Vaswani <avaswani at apple.com>'s
request for review:
Bug 91228: imagemap without a "name" attribute doesn't work (affects xkcd.com)
https://bugs.webkit.org/show_bug.cgi?id=91228
Attachment 167178: Patch
https://bugs.webkit.org/attachment.cgi?id=167178&action=review
------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=167178&action=review
> Source/WebCore/html/HTMLMapElement.cpp:109
> + cachedValue = newValue;
> +
> +}
Extra newline.
> LayoutTests/ChangeLog:10
> + * fast/loader/map-images-to-id-and-name-expected.txt: Added.
> + * fast/loader/map-images-to-id-and-name.html: Added.
> + * fast/loader/resources/circle-and-square.png: Added.
The test should go in fast/images
More information about the webkit-reviews
mailing list