[webkit-reviews] review granted: [Bug 97298] [Refactoring] Introduce a traversal strategy in SelectorChecker : [Attachment 167073] Fix a performance test.

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted Hayato Ito <hayato at chromium.org>'s
request for review:
Bug 97298: [Refactoring] Introduce a traversal strategy in SelectorChecker
https://bugs.webkit.org/show_bug.cgi?id=97298

Attachment 167073: Fix a performance test.
https://bugs.webkit.org/attachment.cgi?id=167073&action=review

------- Additional Comments from Antti Koivisto <koivisto at iki.fi>
View in context: https://bugs.webkit.org/attachment.cgi?id=167073&action=review


I'm bit unhappy about having to make this code generic and so harder to
understand. The reasons given are about Shadow DOM and I can't evaluate if they
are valid or not. The patch itself seems ok so I'll r+ it anyway.

> Source/WebCore/ChangeLog:29
> +	   The performance of the added test before using this patch was:
> +	     avg 3669.143396776992 runs/s
> +	     median 3667.9394112696314 runs/s
> +	     stdev 21.12345296601369 runs/s
> +	     min 3594.5452776430134 runs/s
> +	     max 3707.408251056703 runs/s
> +
> +	   When we used this patch, the performance was:
> +	     avg 3851.376555590946 runs/s
> +	     median 3858.343345260435 runs/s
> +	     stdev 25.245683967249494 runs/s
> +	     min 3782.510878241754 runs/s
> +	     max 3878.4305938425096 runs/s

Can you explain where the performance gains are coming from?