[webkit-reviews] review granted: [Bug 98433] Crash in Safari at com.apple.JavaScriptCore: WTF::StringImpl::is8Bit const + 12 : [Attachment 167152] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Oct 4 11:50:48 PDT 2012


Jessie Berlin <jberlin at webkit.org> has granted Michael Saboff
<msaboff at apple.com>'s request for review:
Bug 98433: Crash in Safari at com.apple.JavaScriptCore: WTF::StringImpl::is8Bit
const + 12
https://bugs.webkit.org/show_bug.cgi?id=98433

Attachment 167152: Patch
https://bugs.webkit.org/attachment.cgi?id=167152&action=review

------- Additional Comments from Jessie Berlin <jberlin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=167152&action=review


> Source/JavaScriptCore/ChangeLog:11
> +	   (JSValueMakeFromJSONString):

You should also mention that characters16() does the is8Bit() check, which is
why you changed it to characters().


More information about the webkit-reviews mailing list