[webkit-reviews] review granted: [Bug 86146] Implement css3-conditional's @supports rule : [Attachment 160546] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted Pablo Flouret
<pablof at motorola.com>'s request for review:
Bug 86146: Implement css3-conditional's @supports rule
https://bugs.webkit.org/show_bug.cgi?id=86146

Attachment 160546: Patch
https://bugs.webkit.org/attachment.cgi?id=160546&action=review

------- Additional Comments from Antti Koivisto <koivisto at iki.fi>
View in context: https://bugs.webkit.org/attachment.cgi?id=160546&action=review


> Source/WebCore/css/CSSGrammar.y:663
>    ;
>  
> +supports:
> +    SUPPORTS_SYM maybe_space supports_condition '{' maybe_space
block_rule_list save_block {

I think it would be good to add feature #if to the grammar too so keep track of
everything that belongs to this feature. Bug 94290 has a WIP patch...